fix(Scanner): Use time based limit for the transaction #56290
+152
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
CarlSchwan,
icewind1991,
leftybournes and
yemkareems
and removed request for
a team
artonge
force-pushed
the
artonge/fix/use_time_limit_in_scanner
branch
from
3f93896 to
ca2607d
Compare
artonge
added
bug
feature: files
php
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
artonge
force-pushed
the
artonge/fix/use_time_limit_in_scanner
branch
2 times, most recently
from
cfafeeb to
7c8f80a
Compare
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/use_time_limit_in_scanner
branch
7 times, most recently
from
d0b1ab7 to
618bd87
Compare
Using the node count does not help if handling a node is slow. Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/use_time_limit_in_scanner
branch
from
618bd87 to
d63a245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the node count does not help if handling a node is slow.
This prevent locking the database for unknown amount of time.
10 seconds is arbitrary, but I don't see any reason to no go even lower.