perf(s3): Cache whether bucket exists #56395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we call doesBucketExist all the time which does a network request to the S3 server adding some non-trivial latency when creating a S3 connection object. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
come-nc and
yemkareems
and removed request for
a team
come-nc
reviewed
Nov 13, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
I do not see any TTL for the caching, how long is it?
Should we reset the cache on failed write/read or something?
artonge
approved these changes
Nov 19, 2025
provokateurin
approved these changes
Nov 19, 2025
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Member
Author
The default, so one day.
If the admin delete the bucket or the bucket become unavailable, I don't think this is a recoverable error and we will simply return a 500 error. |
come-nc
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Otherwise, we call doesBucketExist all the time which does a network request to the S3 server adding some non-trivial latency when creating a S3 connection object.
Checklist
3. to review, feature component)stable32)