Skip to content

refactor(ServerVersion): Add missing type hinting #56491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 2 commits into from
Nov 21, 2025
Merged

refactor(ServerVersion): Add missing type hinting #56491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4356e6
refactor(ServerVersion): Add missing type hinting
CarlSchwan Nov 17, 2025
33d2664
ci: Bump lint-php-cs job to PHP 8.2
CarlSchwan Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-php-cs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: Set up php8.1
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: 8.1
php-version: 8.2
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
Expand Down
8 changes: 6 additions & 2 deletions lib/public/ServerVersion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,15 @@

namespace OCP;

use OCP\AppFramework\Attribute\Consumable;

/**
* @since 31.0.0
*/
class ServerVersion {
#[Consumable(since: '31.0.0')]
readonly class ServerVersion {

/** @var int[] */
private array $version;
private string $versionString;
private string $build;
Expand Down Expand Up @@ -59,6 +63,7 @@ public function getPatchVersion(): int {
}

/**
* @return int[]
* @since 31.0.0
*/
public function getVersion(): array {
Expand Down Expand Up @@ -103,6 +108,5 @@ public function getHumanVersion(): string {
$version .= ' Build:' . $build;
}
return $version;

}
}
Loading