-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflowengine #565
Add workflowengine #565
Conversation
@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @nickvergessen and @icewind1991 to be potential reviewers |
https://github.com/nextcloud/files_accesscontrol <- this app then shows the UI for the workflow engine with regard to the access control rules. |
56afa98
to
0e5114d
Compare
|
||
return [ | ||
'routes' => [ | ||
['name' => 'flowOperations#getChecks', 'url' => '/checks', 'verb' => 'GET'], // TODO rm and do via js? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should this be done via JS? -> let's move this to another issue/PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already made a PR in #582
Tests fail Oo
Integration tests is missing the app on the provisioning tests |
Created issues for everything, lets just fix the tests here, thats the most important. |
If I comment out Lines 433 to 466 in 55fc653
|
👍 |
Fine by me if the mentioned stuff gets tackled. |
cc @nickvergessen