fix(webdav_search):prevents non-numeric coerce as numeric warning #56647
Conversation
Signed-off-by: Israel Saba <israelsaba@gmail.com>
Signed-off-by: Israel Saba <israelsaba@gmail.com>
israelsaba
requested review from
Altahrim,
come-nc,
salmart-dev and
yemkareems
and removed request for
a team
israelsaba
changed the title
| if (is_int($value) || is_float($value)) { | ||
| return 0 + $value; | ||
| } | ||
| $v = filter_var($value, FILTER_VALIDATE_FLOAT); | ||
| return $v === false ? 0 : $v; |
There was a problem hiding this comment.
That means bad values are now silently cast to 0? I’m not sure if it’s a good idea. It would be better to start by fixing the dashboard widget that is causing the logging?
I would prefer an is_numeric test and at least logging (debug or even info) that there’s an issue, if possible with more info than the PHP warning.
There was a problem hiding this comment.
I agree - if its an invalid value it should still fail and not be casted to a different valid value.
So one would not be able to properly detect wrong behaving code.
Meaning in that case the dashboard widget should be fixed as well
|
This is not a warning because of coerce values but a real issue. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
4 participants
Resolves issue: 55812
After PHP 8.1, it emmits a warning when coercing non-numeric values into numeric. This PR solves the warning
A non-numeric value encountered at /var/www/html/apps/dav/lib/Files/FileSearchBackend.php#485that floods the users affect by this issue.