fix(setup): normalize canonical webroot consistently #56853
+27
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent double-slash artifacts caused when non-CLI returned '/' for root. And make the underlying implementation consistent.
''for root installs,'/subpath'for subdirectory installs)For ease of review (since I also did a refactor to streamline things), the problematic lines were 534 & 536 in master. CLI mode always made sure to drop the trailing slash and thus handled a root installation fine by returning '
'(correct behavior):But the non-CLI mode code path would return
'/'(inconsistent with CLI mode and also incorrect) for the same root installation:Often not a serious problem, but was technically incorrect nonetheless.
TODO
Checklist
3. to review, feature component)stable32)