refactor(setup): improve htaccess update handling and code clarity #56857
+199
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtrichards
added
enhancement
feature: install and update
♻️ refactor
joshtrichards
requested review from
ArtificialOwl,
CarlSchwan,
icewind1991 and
leftybournes
and removed request for
a team
Optimize the .htaccess and data-dir protection updates and more defensive. - make the write idempotent so we only update file when the generated block actually changes - more robust read/write/existence checks - improve low disk space guard - additional docblocks/comment clarity Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/refactor-setup-htaccess-updates
branch
from
cffbae6 to
7473f2c
Compare
Versus the installroot/webroot .htaccess Signed-off-by: Josh <josh.t.richards@gmail.com>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimize the .htaccess and data-dir protection update handling and make more defensive.
TODO
Checklist
3. to review, feature component)stable32)