fix(css): correct boundaries of breaking points #57010
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mixed the logic of breaking points (when to break), this makes it consistent: Mobile breaking point is 1024px, so it is applied to width < 1024 and starting with 1024 its "normal". So we consistently have: width < 512px: small mobile 512 <= width < 1024px: mobile width >= 1024px: normal Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
nfebe,
sorbaugh and
szaimen
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
CarlSchwan
approved these changes
Dec 11, 2025
artonge
approved these changes
Dec 12, 2025
Member
|
/backport a95d781 to stable32 |
1 similar comment
Contributor
Author
|
/backport a95d781 to stable32 |
Contributor
Author
|
/backport a95d781 to stable31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We mixed the logic of breaking points (when to break), this makes it consistent:
Mobile breaking point is 1024px, so it is applied to width < 1024 and starting with 1024 its "normal".
So we consistently have:
width < 512px: small mobile
512 <= width < 1024px: mobile
width >= 1024px: normal
Checklist
3. to review, feature component)stable32)