Skip to content

Conversation

@abhinavohri
Copy link
Contributor

Summary

Do not show a success toast if the file rename operation is a success as renaming the file optimistically already provides enough feedback to the user.

TODO

  • ...

Checklist

@abhinavohri abhinavohri requested review from a team and skjnldsv as code owners December 18, 2025 10:05
@abhinavohri abhinavohri requested review from nfebe and sorbaugh and removed request for a team December 18, 2025 10:05
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@susnux susnux added this to the Nextcloud 33 milestone Jan 20, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 20, 2026
@artonge
Copy link
Contributor

artonge commented Jan 20, 2026

@abhinavohri sorry for the long delay here... can you grant us write permissions on your PR?

@abhinavohri
Copy link
Contributor Author

@artonge no problem. I have already provided access to maintainers.
image

@artonge
Copy link
Contributor

artonge commented Jan 20, 2026

/compile rebase /

abhinavohri and others added 2 commits January 20, 2026 15:04
Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
@Altahrim Altahrim merged commit 41ec34c into nextcloud:master Jan 20, 2026
111 of 114 checks passed
@artonge
Copy link
Contributor

artonge commented Jan 20, 2026

Thank you for the contribution @abhinavohri !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: File being renamed flashes a long banner across the top of my Nextcloud in my browser, it's annoying

4 participants