-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
enhancement(files): remove redundant success toast on file rename #57168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@abhinavohri sorry for the long delay here... can you grant us write permissions on your PR? |
|
@artonge no problem. I have already provided access to maintainers. |
|
/compile rebase / |
Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
|
Thank you for the contribution @abhinavohri ! |

Summary
Do not show a success toast if the file rename operation is a success as renaming the file optimistically already provides enough feedback to the user.
TODO
Checklist
3. to review, feature component)stable32)