Skip to content

Conversation

@iasdeoupxe
Copy link

Summary

Note: Also moved one text entry up to have sorted it correctly like others.

TODO

N/A

Checklist

@iasdeoupxe iasdeoupxe requested a review from a team as a code owner January 10, 2026 13:48
@iasdeoupxe iasdeoupxe requested review from Altahrim, nfebe, provokateurin and sorbaugh and removed request for a team January 10, 2026 13:48
@AndyScherzinger
Copy link
Member

Looks good overall, yet I am wondering if it is also missing a repair step, like
https://github.com/nextcloud/server/pull/51703/changes which would then need to be for 33.0.0 - right @CarlSchwan @Altahrim ?

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think so.

@iasdeoupxe iasdeoupxe changed the title feat: Add mimetype aliases/mapping/names for .toml and .ovpn feat(mimetypes): Add mimetype aliases/mapping/names for .toml and .ovpn Jan 19, 2026
@iasdeoupxe
Copy link
Author

Repair thing needs be done by some one else then, not much idea about PHP and i don't want to touch anything called "repair" as too risky for me.

@provokateurin
Copy link
Member

You can basically copy the exact changes from the link, but adjusted with your mimetypes.

iasdeoupxe and others added 2 commits January 19, 2026 18:44
Signed-off-by: iasdeoupxe <39667843+iasdeoupxe@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Copy link
Member

@provokateurin I took the liberty to rebase and add 2871bc9 - please feel free to re-review (if my change) is sufficient 🙏

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 19, 2026

also @provokateurin @Altahrim @CarlSchwan if I look at https://github.com/nextcloud/server/pull/54447/changes#diff-d08941a4637c8c4f1f8696a141bc55d59d10352e2338015e9f675fc86fdbf2bf there are also further files that get touched, not sure this would also apply here (not an expert on the mime-type implementation)
Plus also 397910c suggesting signatures need to be re-calculated (!)

@iasdeoupxe
Copy link
Author

iasdeoupxe commented Jan 19, 2026

Repair topic would need be done by some one else then, i'm not submitting code i'm not able to test (which is the case here). 🙁

This was referenced Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants