perf(files): Optimize CacheEntry creation

[CarlSchwan]

• Resolves: #

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[icewind1991]

Weird that this makes such a difference...

[CarlSchwan]

Weird that this makes such a difference...

Not really, array in php are copy on write. So each assignment create a copy.

[icewind1991]

I'm not sure if not allowing arbitrary fields doesn't break things

[Altahrim]

Maybe we can detect those cases and add a warning for them?

[CarlSchwan]

I'm not sure if not allowing arbitrary fields doesn't break things

So I checked https://github.com/search?q=org%3Anextcloud%20cacheEntryFromData&type=code and the only apps that use cacheEntryFromData are: deck, circles, talk and groupfolders.

For deck, circles and talk it's about sharing and these are the same additional fields as sharing on server

For groupfolders, I added the specific fields from groupfolders. It reduces a bit the optimization when listing the groupfolders but there should be significantly less groupfolders than normal files/folders, so this should be fine

[icewind1991]

Thanks for checking, I think there might be some other places that set their own fields in CacheWrapper::formatCacheEntry but those are done after the constructor so shouldn't be impacted by this.