Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 16, 2026

Summary

The API was not yet deprecated but is not used anymore, so

  1. added a deprecation so we can get rid of it in the future.
  2. But until then we need to drop jQuery so refactored the code to use vanilla JS.

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Jan 16, 2026
@susnux susnux added the 3. to review Waiting for reviews label Jan 16, 2026
@susnux susnux requested a review from a team as a code owner January 16, 2026 11:31
@susnux susnux added technical debt ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 16, 2026
@susnux susnux requested review from nfebe, sorbaugh and szaimen and removed request for a team January 16, 2026 11:31
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

The API was not yet deprecated but is not used anymore,
so 1. added a deprecation so we can get rid of it in the future.
But until then we need to drop jQuery so refactored the code to use
vanilla JS.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the refactor/ocp-comments branch from 4ed7647 to 1163638 Compare January 16, 2026 13:21
@susnux
Copy link
Contributor Author

susnux commented Jan 16, 2026

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 6a67456 into master Jan 16, 2026
222 of 234 checks passed
@susnux susnux deleted the refactor/ocp-comments branch January 16, 2026 16:25
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants