Skip to content

fix(activity): allow string types for snowflake IDs #57655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
Jan 21, 2026
Merged

fix(activity): allow string types for snowflake IDs #57655

AndyScherzinger merged 1 commit into from
Jan 21, 2026
+5 −5

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Jan 20, 2026 •
edited
Loading

Summary

Fixes Activity App CI

TODO

  • ...

Checklist

@miaulalala miaulalala added this to the Nextcloud 33 milestone Jan 20, 2026
@miaulalala miaulalala self-assigned this Jan 20, 2026
@miaulalala miaulalala requested a review from a team as a code owner January 20, 2026 11:26
@miaulalala miaulalala added the bug label Jan 20, 2026
@miaulalala miaulalala requested review from ArtificialOwl, CarlSchwan and leftybournes and removed request for a team January 20, 2026 11:26
@miaulalala miaulalala added the 3. to review Waiting for reviews label Jan 20, 2026
@miaulalala miaulalala requested a review from come-nc January 20, 2026 11:26
@miaulalala miaulalala requested review from a team and nickvergessen January 20, 2026 11:26
@miaulalala miaulalala mentioned this pull request Jan 20, 2026
Closed
7 tasks
nickvergessen
nickvergessen reviewed Jan 20, 2026
View reviewed changes
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 20, 2026
Merged
come-nc
come-nc reviewed Jan 20, 2026
View reviewed changes
@miaulalala
fix(activity): allow string types for snowflake IDs
f9a159e 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the fix/noid/typing-activity-manager branch from a367c84 to f9a159e Compare January 21, 2026 16:37
szaimen
szaimen approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzinger AndyScherzinger merged commit a9f3534 into master Jan 21, 2026
208 of 217 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/noid/typing-activity-manager branch January 21, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@szaimen szaimen szaimen approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@miaulalala miaulalala

Labels

3. to review Waiting for reviews bug feature: activity and notification

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

7 participants

@miaulalala @nickvergessen @AndyScherzinger @ChristophWurst @szaimen @come-nc