Skip to content

[stable31] fix(userconfig): duplicate core lexicon #57743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
Jan 25, 2026
Merged

[stable31] fix(userconfig): duplicate core lexicon #57743

AndyScherzinger merged 1 commit into from
Jan 25, 2026
+5 −47

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 22, 2026

Backport #54082

@ArtificialOwl @come-nc
fix(userconfig): duplicate core lexicon
7afcbdc 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@come-nc come-nc added this to the Nextcloud 31.0.14 milestone Jan 22, 2026
@come-nc come-nc self-assigned this Jan 22, 2026
@come-nc come-nc added the 3. to review Waiting for reviews label Jan 22, 2026
@solracsf solracsf requested review from artonge and susnux January 25, 2026 13:02
AndyScherzinger
AndyScherzinger approved these changes Jan 25, 2026
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzinger AndyScherzinger merged commit f5c279a into stable31 Jan 25, 2026
206 of 215 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/54082/stable31 branch January 25, 2026 23:06
@pako81
Copy link

pako81 commented Jan 28, 2026 •
edited
Loading

Thanks for the fix! However, it is still not possible to change the user's locale as it comes to a NCU\\Config\\Exceptions\\TypeConflictException","Message":"conflict between new type (mixed) and old type (string) exception.

Tested on 31.0.12 + this patch.

You may probably want to consider adding a new ConfigLexiconEntry for the user's locale in the getUserConfigs() method?

@susnux
Copy link
Contributor

susnux commented Jan 28, 2026

@pako81 if possible you can also create a PR fixing this.
We highly appreciate the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@solracsf solracsf solracsf approved these changes

@artonge artonge Awaiting requested review from artonge

@susnux susnux Awaiting requested review from susnux

Assignees

@come-nc come-nc

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 31.0.14

Development

Successfully merging this pull request may close these issues.

7 participants

@come-nc @pako81 @susnux @AndyScherzinger @solracsf @ArtificialOwl