Skip to content

fix(caldav): Enhance UID check for base component #57758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
solracsf merged 1 commit into from
Jan 23, 2026
Merged

fix(caldav): Enhance UID check for base component #57758

solracsf merged 1 commit into from
Jan 23, 2026
+2 −1

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Jan 23, 2026 •
edited by ChristophWurst
Loading

Summary

Added a check to skip processing if the base component is null or UID is not set.

Checklist

@solracsf solracsf added this to the Nextcloud 34 milestone Jan 23, 2026
@solracsf solracsf added the bug label Jan 23, 2026
@solracsf solracsf requested a review from tcitworld as a code owner January 23, 2026 14:59
@solracsf solracsf added 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Jan 23, 2026
@solracsf
Copy link
Member Author

solracsf commented Jan 23, 2026

/backport to stable33

@solracsf
Copy link
Member Author

solracsf commented Jan 23, 2026

/backport to stable32

@solracsf
Copy link
Member Author

solracsf commented Jan 23, 2026

/backport to stable31

@solracsf solracsf enabled auto-merge January 23, 2026 14:59
@solracsf solracsf self-assigned this Jan 23, 2026
ChristophWurst
ChristophWurst approved these changes Jan 23, 2026
View reviewed changes
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 23, 2026
@solracsf solracsf disabled auto-merge January 23, 2026 16:21
@solracsf
fix(caldav): Enhance UID check for base component
59bb049 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the fixNoBaseComponentFound branch from 242c053 to 59bb049 Compare January 23, 2026 16:24
@solracsf solracsf enabled auto-merge January 23, 2026 16:25
@solracsf solracsf merged commit 0c83a9d into master Jan 23, 2026
184 of 190 checks passed
@solracsf solracsf deleted the fixNoBaseComponentFound branch January 23, 2026 18:24
This was referenced Jan 23, 2026
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@solracsf solracsf

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

RefreshWebcalService "Attempt to read property UID on null"

4 participants

@solracsf @ChristophWurst @SebastianKrupinski