fix(user_ldap): Fix crash in some code path when a DN is longer that 64 #57844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UserConfig throws in this case. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
sorbaugh
and removed request for
a team
Altahrim
approved these changes
Jan 27, 2026
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
CarlSchwan
approved these changes
Jan 28, 2026
This was referenced Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UserConfig throws when given an invalid user id, which is new.
So catch the exception and ignore it. (in user_ldap we sometimes do not know if we are manipulating a user id or a DN)
Checklist
3. to review, feature component)stable32)