Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ownCloud -> Nextcloud #630

Merged
merged 3 commits into from
Jul 29, 2016
Merged

ownCloud -> Nextcloud #630

merged 3 commits into from
Jul 29, 2016

Conversation

enoch85
Copy link
Member

@enoch85 enoch85 commented Jul 28, 2016

cc @nextcloud/developers

@LukasReschke
Copy link
Member

👍

@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Jul 28, 2016
@LukasReschke LukasReschke added this to the Nextcloud 10.0 milestone Jul 28, 2016
@AndyScherzinger
Copy link
Member

👍

@LukasReschke LukasReschke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 28, 2016
@jancborchardt
Copy link
Member

Hahahaha 👍 – can you also prepare backports to stable10 and stable9?

@enoch85
Copy link
Member Author

enoch85 commented Jul 28, 2016

@jancborchardt Maybe ;)

@nickvergessen
Copy link
Member

I hope this doesn't break integration tests 🙈

@LukasReschke
Copy link
Member

Oh. Right. It likely will do that 🎉

@nickvergessen
Copy link
Member

Viola, please fix @enoch85 files:

  • build/integration/features/webdav-related.feature
  • build/integration/features/dav-v2.feature

@nickvergessen nickvergessen added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jul 28, 2016
@nickvergessen
Copy link
Member

And while you are on it, there is more ownCloud writing in the integration tests ;)

@enoch85
Copy link
Member Author

enoch85 commented Jul 28, 2016

Tried find . -type f -exec sed -i 's|ownCloud|Nextcloud|g' {} + but it wasn't that easy. :(

@MorrisJobke
Copy link
Member

MorrisJobke commented Jul 28, 2016

    /drone/src/github.com/nextcloud/server/build/integration/features/dav-v2.feature:12
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:12
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:35
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:44
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:62
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:144
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:151
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:165
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:179
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:191

@enoch85
Copy link
Member Author

enoch85 commented Jul 28, 2016

@MorrisJobke and what does that mean?

@MorrisJobke
Copy link
Member

@MorrisJobke and what does that mean?

I will fix them.

Oh sorry. Those are the failing tests. Forgot to copy the line above.

@enoch85
Copy link
Member Author

enoch85 commented Jul 28, 2016

I will fix them.

@MorrisJobke Thanks!!

@rullzer
Copy link
Member

rullzer commented Jul 29, 2016

@MorrisJobke you missed a few:

--- Failed scenarios:

    /drone/src/github.com/nextcloud/server/build/integration/features/sharing-v1.feature:304
    /drone/src/github.com/nextcloud/server/build/integration/features/sharing-v1.feature:488
    /drone/src/github.com/nextcloud/server/build/integration/features/sharing-v1.feature:509
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:35
    /drone/src/github.com/nextcloud/server/build/integration/features/webdav-related.feature:44

@MorrisJobke
Copy link
Member

@MorrisJobke you missed a few:

Fixed them too.

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 29, 2016
@rullzer rullzer merged commit 41d044c into master Jul 29, 2016
@rullzer rullzer deleted the enoch85-patch-1 branch July 29, 2016 08:55
GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016
@rullzer rullzer mentioned this pull request Mar 26, 2021
2 tasks
@rullzer rullzer mentioned this pull request Apr 8, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants