Add direct preview link #6599

rullzer · 2017-09-21T09:58:26Z

Should fix #2523

Turns out it was easier to just do it then to tell @jancborchardt to shut up again 💋 😉

Requires:

Handle SameSiteCookie check for index.php in AppFramework Middleware #6630

jancborchardt · 2017-09-21T10:02:36Z

Also cc the others from issue #2523 for review: @jm-andonegi @Cerberus-tm @oliverpool @shyamal890 @drjagan @io-node @Happyfeet01– please check it out! :)

rullzer · 2017-09-21T10:05:58Z

Ok so we need actual samesite cookie work here to make it work. So this is not as simple... I'll look into that.

juliusknorr · 2017-09-21T10:19:03Z

apps/files_sharing/templates/public.php

@@ -92,7 +92,7 @@
 				</div>
 				<div class="directLink">
 					<label for="directLink"><?php p($l->t('Direct link')) ?></label>
-					<input id="directLink" type="text" readonly value="<?php p($_['downloadURL']); ?>">
+					<input id="directLink" type="text" readonly value="<?php p($_['previewURL']); ?>">


This will not work when you share a file that is not an image, right? We should still show the direct download link then.

We don't, for non preview types it is set to the downloadurl in the controller.

Ah, I've missed that it is being set there, nevermind.

rullzer · 2017-09-24T11:04:16Z

This requires #6630 to work properly. I'll update once that is in.

MorrisJobke · 2017-09-25T14:17:47Z

This requires #6630 to work properly. I'll update once that is in.

Done. Now don our work ;)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

codecov · 2017-09-25T14:19:08Z

Codecov Report

Merging #6599 into master will decrease coverage by 0.01%.
The diff coverage is 9.37%.

@@             Coverage Diff              @@
##             master    #6599      +/-   ##
============================================
- Coverage     53.06%   53.05%   -0.02%     
- Complexity    22567    22580      +13     
============================================
  Files          1417     1417              
  Lines         87800    87833      +33     
  Branches       1340     1340              
============================================
+ Hits          46594    46599       +5     
- Misses        41206    41234      +28

Impacted Files	Coverage Δ	Complexity Δ
apps/files_sharing/templates/public.php	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
core/routes.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...sharing/lib/Controller/PublicPreviewController.php	`36.36% <0%> (-22.46%)`	`18 <8> (+8)`
lib/private/Preview/Generator.php	`84.56% <33.33%> (-1.06%)`	`44 <0> (+2)`
...s/files_sharing/lib/Controller/ShareController.php	`46.59% <66.66%> (+0.21%)`	`61 <0> (+1)`	⬆️
lib/private/Server.php	`84.24% <0%> (-0.13%)`	`123% <0%> (ø)`
...vate/Authentication/Token/DefaultTokenProvider.php	`94.31% <0%> (+0.06%)`	`26% <0%> (ø)`	⬇️
lib/private/Security/CertificateManager.php	`92.07% <0%> (+0.99%)`	`39% <0%> (ø)`	⬇️
lib/private/Files/Cache/Propagator.php	`96.2% <0%> (+1.26%)`	`16% <0%> (ø)`	⬇️

rullzer · 2017-09-25T14:20:23Z

DONE! Lets get this in as well so @jancborchardt owes me a 🍺 :)

MorrisJobke

Works, but for example for text files this is quite suboptimal, because you get the preview instead :/

MorrisJobke

And the unit tests fail

rullzer · 2017-09-25T19:47:57Z

Test should be fixed. The preview endpoint is now only used for image types we can generate previews for.

Fixed

MorrisJobke

Tested and works 👍

X4LD1M0 · 2017-09-26T18:32:35Z

Just a question, I am trying out this feature, am I correct I take the share-link and append "/preview" to make it work? Or is there an automated way to get this specific link?

rullzer · 2017-09-26T18:55:24Z

@io-node that is correct.

However, if you just share a picture via public link. It should show up in the text feel below the preview.

X4LD1M0 · 2017-09-26T19:24:26Z

OK so if i understand it correctly:

Create a share link of photo
Copy share link
Past share link where required and append '/preview'

It does work as mentioned above. I assume once 13 is being released it will be noted somewhere (on the web-page) how to use this.

rullzer · 2017-09-26T20:08:40Z

@io-node correct.

But if you open the share link. There should be a button (download) and a field direct link below the image.

X4LD1M0 · 2017-09-26T20:24:36Z

Yes the 'direct link' i can see just under the image but this can only be used internally for users who have an account (and access to the relevant folder). I just expected there be a separate box/link to provide the preview link (if a preview is possible)

So to summarise, I expected a standard link (as normal), and (if preview is available) a preview link. This way you can share a photo still easy in the normal way (including the NC theming) and have a separate link which can be used if using it on other sites as a direct link.

rullzer · 2017-09-26T20:38:12Z

No no the link is at the public page:

See the bottom selected text

X4LD1M0 · 2017-09-26T20:45:07Z

Thank you 😊 sorry for the confusion. I get now what you mean. OK that works also. As an 'expert' one can always use the normal link and add the "/preview" behind it, but for novice users they can use the method you mentioned.

Do like how it works and does exactly 'as is written on the box' 😄

I do have a little comment, since it does any image MIME type of files, the problem is with GIF animations it won't work, since it will only do a (static) preview. Can I assume this is an accepted limitation? Or is there a way to make an animated preview for GIFs?

jancborchardt

Looks good! Finally ;)

eppfel · 2017-09-28T09:57:15Z

Awesome everyone! 😍 Sry, for being absent in recent time. Moving to Finland 🇫🇮 New job and all.

DarkScientist · 2019-02-14T17:51:43Z

Hi, any way to get a direct link to the image file ? I want a link who point to a .jpeg file for example...

schniewmatz · 2019-04-30T20:03:46Z

Hi thank you for this advance :)
Is there any option to make this work also for .svg files?

rullzer added 3. to review Waiting for reviews enhancement feature: files feature: sharing labels Sep 21, 2017

rullzer added this to the Nextcloud 13 milestone Sep 21, 2017

rullzer requested review from nickvergessen, MorrisJobke, LukasReschke, jancborchardt and ChristophWurst September 21, 2017 09:58

jancborchardt mentioned this pull request Sep 21, 2017

Make Nextcloud a great image hosting/upload service #2523

Closed

jancborchardt requested a review from eppfel September 21, 2017 10:03

rullzer added 1. to develop Accepted and waiting to be taken care of and removed 3. to review Waiting for reviews labels Sep 21, 2017

juliusknorr reviewed Sep 21, 2017

View reviewed changes

rullzer added 4 commits September 25, 2017 16:18

Allow requesting the max preview

29fb315

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Add direct preview link to single shared image files

7d8c5f7

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

For images we have a preview for use the preview link

894958e

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Add annotation

c3491e3

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer force-pushed the fix_2523 branch from 476aa20 to c3491e3 Compare September 25, 2017 14:18

rullzer added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Sep 25, 2017

MorrisJobke approved these changes Sep 25, 2017

View reviewed changes

MorrisJobke previously requested changes Sep 25, 2017

View reviewed changes

rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 25, 2017

MorrisJobke approved these changes Sep 26, 2017

View reviewed changes

jancborchardt approved these changes Sep 27, 2017

View reviewed changes

MorrisJobke merged commit 5f25dd7 into master Sep 27, 2017

MorrisJobke deleted the fix_2523 branch September 27, 2017 21:28

danxuliu mentioned this pull request Dec 22, 2017

Image preview in sharing page should show the full image #7614

Closed

tflidd mentioned this pull request Feb 26, 2018

Put image hosting-function into documentation nextcloud/documentation#696

Open

mcnesium mentioned this pull request Jul 10, 2018

no shared audio and video embedding #10174

Closed

jcklpe mentioned this pull request Dec 10, 2018

Allow access to text files raw contents using some kind of preview system? #12986

Closed

This was referenced Apr 24, 2019

Inline preview and popup of Attached Images. nextcloud/deck#972

Closed

Feature Request: Markdown support in Circle descriptions nextcloud/circles#289

Closed

pierreozoux mentioned this pull request Sep 16, 2020

Embed pdf on other site nextcloud/files_pdfviewer#229

Closed

Cwpute mentioned this pull request Aug 7, 2023

More visibility for Preview feature in shared links #39742

Open

joshtrichards added feature: previews and thumbnails feature: files and removed feature: files feature: previews and thumbnails labels Aug 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add direct preview link #6599

Add direct preview link #6599

rullzer commented Sep 21, 2017 •

edited by MorrisJobke

Loading

jancborchardt commented Sep 21, 2017

rullzer commented Sep 21, 2017

juliusknorr Sep 21, 2017

rullzer Sep 23, 2017

juliusknorr Sep 23, 2017

rullzer commented Sep 24, 2017

MorrisJobke commented Sep 25, 2017

codecov bot commented Sep 25, 2017 •

edited

Loading

rullzer commented Sep 25, 2017

MorrisJobke left a comment

MorrisJobke left a comment

rullzer commented Sep 25, 2017

MorrisJobke left a comment

X4LD1M0 commented Sep 26, 2017

rullzer commented Sep 26, 2017

X4LD1M0 commented Sep 26, 2017

rullzer commented Sep 26, 2017

X4LD1M0 commented Sep 26, 2017 •

edited

Loading

rullzer commented Sep 26, 2017

X4LD1M0 commented Sep 26, 2017 •

edited

Loading

jancborchardt left a comment

eppfel commented Sep 28, 2017

DarkScientist commented Feb 14, 2019

schniewmatz commented Apr 30, 2019

Add direct preview link #6599

Add direct preview link #6599

Conversation

rullzer commented Sep 21, 2017 • edited by MorrisJobke Loading

jancborchardt commented Sep 21, 2017

rullzer commented Sep 21, 2017

juliusknorr Sep 21, 2017

Choose a reason for hiding this comment

rullzer Sep 23, 2017

Choose a reason for hiding this comment

juliusknorr Sep 23, 2017

Choose a reason for hiding this comment

rullzer commented Sep 24, 2017

MorrisJobke commented Sep 25, 2017

codecov bot commented Sep 25, 2017 • edited Loading

Codecov Report

rullzer commented Sep 25, 2017

MorrisJobke left a comment

Choose a reason for hiding this comment

MorrisJobke left a comment

Choose a reason for hiding this comment

rullzer commented Sep 25, 2017

MorrisJobke left a comment

Choose a reason for hiding this comment

X4LD1M0 commented Sep 26, 2017

rullzer commented Sep 26, 2017

X4LD1M0 commented Sep 26, 2017

rullzer commented Sep 26, 2017

X4LD1M0 commented Sep 26, 2017 • edited Loading

rullzer commented Sep 26, 2017

X4LD1M0 commented Sep 26, 2017 • edited Loading

jancborchardt left a comment

Choose a reason for hiding this comment

eppfel commented Sep 28, 2017

DarkScientist commented Feb 14, 2019

schniewmatz commented Apr 30, 2019

rullzer commented Sep 21, 2017 •

edited by MorrisJobke

Loading

codecov bot commented Sep 25, 2017 •

edited

Loading

X4LD1M0 commented Sep 26, 2017 •

edited

Loading

X4LD1M0 commented Sep 26, 2017 •

edited

Loading