-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt out of birthday calendar #6884
Opt out of birthday calendar #6884
Conversation
ee309ca
to
96e6509
Compare
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
96e6509
to
60c8e26
Compare
…lendar Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
… hooks Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
e5cff20
to
4d3f33c
Compare
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
4d3f33c
to
2b51d84
Compare
return [ | ||
'routes' => [ | ||
['name' => 'birthday_calendar#enable', 'url' => '/enableBirthdayCalendar', 'verb' => 'POST'], | ||
['name' => 'birthday_calendar#disable', 'url' => '/disableBirthdayCalendar', 'verb' => 'POST'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the same route and POST+DELETE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If using the same route, it would make more sense to send the enable/disable part in the payload and send everything over POST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, what's the benefit of using POST+DELETE instead of the two routes in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting something with a POST request just doesn't feel right to me, anyway not very important
@georgehrke Where can I find the setting for a user? I haven't spotted it yet. |
There is no real setting for that (in the server). When a user deletes their birthday calendar, nextcloud will remember not to generate birthday calendars for that user again. To enable birthday calendar generation again, the user will have to send a special request to their calendar home: We will add a button for that in the calendar app. |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets do this!
@georgehrke |
No, We will add a button for this in the calendar app. Users obviously won't have to send these kind of requests on their own. |
FYI, doing that kinda messed up the contact birthday calendar, then I realized it was due to sync problems. I've deleted it again on NC, deleted in all other synced devices e re-enabled again following your method. Finally it works fine, thank you. The button implementation will be very welcome. |
Although I'd still be curious what the answer is to the above, I've found the solution using occ from a shell:
Where |
Nice to know @srwareham. For doing the trick above you have to live edit the page's html, there are plenty of tools for that. |
For newer nextcloud versions it might be required to run |
fixes #3003
This introduces: