Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If there is no internet connection don't try to contact appstore #7121

Merged
merged 2 commits into from
Nov 17, 2017
Merged

If there is no internet connection don't try to contact appstore #7121

merged 2 commits into from
Nov 17, 2017

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Nov 9, 2017

Fixes #7119

If your instance has no internet connection it makes no sense to try to contact the appstore.

@rullzer rullzer added this to the Nextcloud 13 milestone Nov 9, 2017
@rullzer rullzer mentioned this pull request Nov 9, 2017
Closed
ChristophWurst
ChristophWurst approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In case there is a unit test for this I assume it fo fail, but let's see :)

@MorrisJobke
Copy link
Member

@rullzer The unit tests fail :/

@rullzer
If there is no internet connection don't try to contact appstore
2eb2b6e 
Fixes #7119

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Fix tests
6bbda28 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov
Copy link

codecov bot commented Nov 17, 2017 •
edited
Loading

Codecov Report

Merging #7121 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #7121      +/-   ##
============================================
- Coverage     50.84%   50.84%   -0.01%     
- Complexity    24545    24546       +1     
============================================
  Files          1585     1585              
  Lines         93796    93797       +1     
  Branches       1354     1354              
============================================
- Hits          47689    47688       -1     
- Misses        46107    46109       +2
Impacted Files Coverage Δ Complexity Δ
lib/private/App/AppStore/Fetcher/Fetcher.php 78.26% <100%> (+0.31%) 20 <0> (+1) ⬆️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)

@rullzer rullzer merged commit 07af58d into master Nov 17, 2017
@rullzer rullzer deleted the fix_7119 branch November 17, 2017 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug enhancement feature: apps management
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
4 participants
@rullzer @MorrisJobke @ChristophWurst @skjnldsv