only replace permission popupmenu #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the contacts popovermenu is also present and is being replaces, ending up in two permission popupmenus with checkboxes duplicating the id, breaking further permission changes. plus, fixing a selector Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
3. to review
blizzz
requested review from
MorrisJobke,
georgehrke,
skjnldsv and
GitHubUser4234
Codecov Report
@@ Coverage Diff @@
## master #7211 +/- ##
=========================================
Coverage 50.84% 50.84%
Complexity 24545 24545
=========================================
Files 1585 1585
Lines 93796 93796
Branches 1354 1354
=========================================
Hits 47687 47687
Misses 46109 46109
|
|
There is an open issue with this, but I can't find it! :/ |
skjnldsv
approved these changes
Nov 18, 2017
MorrisJobke
approved these changes
Nov 20, 2017
|
Should be backported. :) |
|
On my list, gets the next free time slice ;) |
|
Backport to 12: #7259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the contacts popovermenu is also present and is being replaces, ending
up in two permission popupmenus with checkboxes duplicating the id,
breaking further permission changes.
plus, fixing a selector
needs backporting to 12
Fix #5916