Use basename() instead of self implementation #7260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
rullzer,
nickvergessen,
icewind1991 and
blizzz
LukasReschke
approved these changes
Nov 23, 2017
There was a problem hiding this comment.
Makes sense. As per owncloud/core#4227 this just seemed to be there for Windows.
blizzz
approved these changes
Nov 23, 2017
MorrisJobke
added
4. to release
Codecov Report
@@ Coverage Diff @@
## master #7260 +/- ##
============================================
- Coverage 50.86% 50.86% -0.01%
+ Complexity 24551 24550 -1
============================================
Files 1585 1585
Lines 93815 93811 -4
Branches 1354 1354
============================================
- Hits 47720 47716 -4
Misses 46095 46095
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried this by keeping the unit tests and they still succeed if I would just use the native
basename()method.@icewind1991 Does that make sense?