Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation of federation scope menu #7346

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

MorrisJobke
Copy link
Member

* l10n in Nextcloud works by extracting the values only passed on their location and not based on the first parameter
* we need to change the translation pool from `core` to `settings` then
* fixes #7345

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@codecov
Copy link

codecov bot commented Nov 30, 2017

Codecov Report

Merging #7346 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7346      +/-   ##
============================================
+ Coverage     50.86%   50.91%   +0.05%     
- Complexity    24541    24698     +157     
============================================
  Files          1584     1583       -1     
  Lines         93804    94110     +306     
  Branches       1358     1358              
============================================
+ Hits          47712    47916     +204     
- Misses        46092    46194     +102
Impacted Files Coverage Δ Complexity Δ
...ib/private/DB/QueryBuilder/CompositeExpression.php 50% <0%> (-12.5%) 6% <0%> (+3%)
apps/dav/lib/DAV/Sharing/Plugin.php 60% <0%> (-3.64%) 14% <0%> (ø)
lib/private/RichObjectStrings/Validator.php 82.14% <0%> (-2.86%) 13% <0%> (+9%)
apps/files_external/lib/Command/ListCommand.php 38.62% <0%> (-2.05%) 39% <0%> (ø)
lib/private/Mail/Message.php 79.16% <0%> (-1.97%) 24% <0%> (+7%)
lib/private/Group/MetaData.php 68.91% <0%> (-1.86%) 19% <0%> (ø)
lib/autoloader.php 79.62% <0%> (-1.63%) 27% <0%> (+12%)
lib/private/Diagnostics/Query.php 36.84% <0%> (-1.62%) 8% <0%> (+3%)
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)
lib/private/Route/Router.php 52.14% <0%> (-0.96%) 50% <0%> (+7%)
... and 36 more

@nickvergessen nickvergessen merged commit 288f50b into master Nov 30, 2017
@nickvergessen nickvergessen deleted the fix-federation-scope-menu-l10n branch November 30, 2017 11:29
@MorrisJobke
Copy link
Member Author

Backport is in #7353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips in personal settings don't get translations
3 participants