Fix error log on PHP 7.2 #7466
Merged
Fix error log on PHP 7.2 #7466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes following error in the logs: "ini_set(): A session is active. You cannot change the session module's ini settings at this time" Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
rullzer,
LukasReschke,
ChristophWurst and
blizzz
rullzer
approved these changes
Dec 12, 2017
blizzz
approved these changes
Dec 12, 2017
blizzz
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes following error in the logs:
ini_set(): A session is active. You cannot change the session module's ini settings at this timeBasically moves the
ini_set5 lines to the top into the method call.Found while testing the 13.0.0 beta 2 on PHP 7.2