Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tha copy share link button properly inline #7476

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

MorrisJobke
Copy link
Member

Before:

bildschirmfoto 2017-12-13 um 10 29 33

After:

bildschirmfoto 2017-12-13 um 10 30 54

cc @nextcloud/designers

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. labels Dec 13, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Dec 13, 2017
@MorrisJobke
Copy link
Member Author

To test this you need to enable one of the social sharing apps.

@codecov
Copy link

codecov bot commented Dec 13, 2017

Codecov Report

Merging #7476 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7476   +/-   ##
=========================================
  Coverage     51.11%   51.11%           
  Complexity    24901    24901           
=========================================
  Files          1601     1601           
  Lines         94773    94773           
  Branches       1367     1367           
=========================================
  Hits          48440    48440           
  Misses        46333    46333
Impacted Files Coverage Δ Complexity Δ
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Server.php 81.01% <0%> (+0.11%) 134% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️

@skjnldsv skjnldsv merged commit fc30e7a into master Dec 13, 2017
@skjnldsv skjnldsv deleted the fix-copy-share-link-design branch December 13, 2017 10:18
@MorrisJobke MorrisJobke mentioned this pull request Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants