Fixes bin2hex() in LDAP #7479
Merged
Fixes bin2hex() in LDAP #7479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untangles the two if-else clauses into a more readable format. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This was referenced Dec 13, 2017
Merged
|
The proof on 3v4l: https://3v4l.org/OdXp2 |
rullzer
reviewed
Dec 13, 2017
| if($this->resemblesDN($key)) { | ||
| $selection[$i][$key] = $this->helper->sanitizeDN($item[$key]); | ||
| } else if($key === 'objectguid' || $key === 'guid') { | ||
| $selection[$i][$key] = [$this->convertObjectGUID2Str($item[$key][0])]; |
There was a problem hiding this comment.
I'm assuming just taking the first element is fine?
There was a problem hiding this comment.
yes, because it is an identifier. if i get my hands on an AD i wanna doublecheck the format, however, and ideally add tests for it
|
As I only took the patch of @blizzz #7400 (comment) I also give this a 👍 |
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untangles the two if-else clauses into a more readable format.
Fixes #7400