-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect sharing options when searching using MailPlugin #7428 #7490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7490 +/- ##
============================================
+ Coverage 51.16% 51.18% +0.01%
- Complexity 24866 24870 +4
============================================
Files 1601 1601
Lines 94684 94696 +12
Branches 1368 1368
============================================
+ Hits 48448 48468 +20
+ Misses 46236 46228 -8
|
Mmm, actually, it seems like my fix isn't 100% correct, because now if you type the full e-mail address the user won't show up.... |
… we may share with Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
I managed to create a better fix. The commit 9d60f7f is now fixing: Steps to reproduce
Expected behaviour
Actual behaviour
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good and works
Tests need to be adjusted, though |
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
@blizzz I fixed the tests and add some test cases for this patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
Yes - please open a backport PR. |
I think I found the problem with #7428, basically when a user
gr2_foo
has set an email address and is in groupgr2
and a user ofgr1
tries to share somethinggr2_foo
will show up. This is of course because there is a match based on the email address. However there shouldn't be searched for systemusers using the mail plugin, because there is the UserPlugin.This can very easily be backported to 12 (I have already pushed a branch) if wanted.