Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cached app list #7506

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Use cached app list #7506

merged 1 commit into from
Dec 14, 2017

Conversation

MorrisJobke
Copy link
Member

Followup to #7264

Before it just fetched the list again and again 🙈

@MorrisJobke
Use cached app list
54c227b 
Followup to #7264

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Dec 14, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Dec 14, 2017
@MorrisJobke
Copy link
Member Author

I also added an unit tests that check this behaviour ;)

skjnldsv
skjnldsv approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! ^^

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 14, 2017
@codecov
Copy link

codecov bot commented Dec 14, 2017 •
edited
Loading

Codecov Report

Merging #7506 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #7506      +/-   ##
============================================
+ Coverage     51.11%   51.16%   +0.05%     
+ Complexity    24903    24865      -38     
============================================
  Files          1601     1601              
  Lines         94778    94683      -95     
  Branches       1368     1368              
============================================
+ Hits          48445    48446       +1     
+ Misses        46333    46237      -96
Impacted Files Coverage Δ Complexity Δ
lib/private/Installer.php 57.64% <100%> (ø) 74 <0> (ø) ⬇️
lib/private/Server.php 80.9% <0%> (-0.12%) 134% <0%> (ø)
...rver_connector/composer/composer/autoload_real.php 0% <0%> (ø) 9% <0%> (-2%) ⬇️
...pps/encryption/composer/composer/autoload_real.php 0% <0%> (ø) 9% <0%> (-2%) ⬇️
...files_versions/composer/composer/autoload_real.php 0% <0%> (ø) 9% <0%> (-2%) ⬇️
apps/oauth2/composer/composer/autoload_real.php 0% <0%> (ø) 9% <0%> (-2%) ⬇️
.../files_sharing/composer/composer/autoload_real.php 0% <0%> (ø) 9% <0%> (-2%) ⬇️
...tenotification/composer/composer/autoload_real.php 0% <0%> (ø) 9% <0%> (-2%) ⬇️
apps/testing/composer/composer/autoload_real.php 0% <0%> (ø) 9% <0%> (-2%) ⬇️
apps/comments/composer/composer/autoload_real.php 0% <0%> (ø) 9% <0%> (-2%) ⬇️
... and 12 more

@MorrisJobke MorrisJobke merged commit 1f10897 into master Dec 14, 2017
@MorrisJobke MorrisJobke deleted the fix-app-cache branch December 14, 2017 09:45
@MorrisJobke MorrisJobke mentioned this pull request Jan 2, 2018
Merged
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer rullzer approved these changes

@schiessle schiessle Awaiting requested review from schiessle

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @rullzer @skjnldsv