[oc] Handle OC-Total-Length in new chunking

[danxuliu]

Imported from owncloud/core#28545.

This pull request ensures that the OC-Total-Length header provided in the final MOVE operation of a chunked upload matches the length of the chunks in the server, aborting the upload if they do not match; it is similar to the check performed for each chunk, but for the whole file instead. Obviously this is not an integrity check, but something to quickly reject an upload if some chunks are missing.

Differences with the original pull request:

• no autoloader files were included in the original commits; those are needed in Nextcloud, so they were updated running composer dump-autoload when the ChunkingPlugin.php file was added.
• sanitizeMTime was different in current master than in master of the original pull request, so when moving it to Node.php the same version as in current master was used
• the units (bytes) were added to the end of the error message
• baseUrlWithoutOCSAppendix does not exist in Nextcloud, so it was replaced by its implementation
• the last commit is not included in this pull request, as it is not related to the rest of the changes and it does not provide much value either

It can be tested by modifying the uploader code of the Web UI to send less bytes than expected (for example, by adding options.blob = options.blob.slice(0, options.blob.size - 1); to the beginning of _initXHRData.

Finally, this pull request should not conflict with the desktop, Android or iOS clients; OC-Total-Length is taken into account when provided in the MOVE operation, but if it is not given the verification is simply skipped.

[codecov]

Codecov Report

Merging #7533 into master will increase coverage by <.01%.
The diff coverage is 85.36%.

@@             Coverage Diff              @@
##             master    #7533      +/-   ##
============================================
+ Coverage     51.16%   51.17%   +<.01%     
- Complexity    24866    24871       +5     
============================================
  Files          1601     1602       +1     
  Lines         94684    94701      +17     
  Branches       1368     1368              
============================================
+ Hits          48448    48459      +11     
- Misses        46236    46242       +6

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/lib/Connector/Sabre/File.php	73.86% <ø> (-0.49%)	101 <0> (-4)
apps/dav/composer/composer/autoload_static.php	0% <ø> (ø)	1 <0> (ø)	⬇️
apps/dav/bin/chunkperf.php	0% <0%> (ø)	0 <0> (ø)	⬇️
apps/dav/composer/composer/autoload_classmap.php	0% <0%> (ø)	0 <0> (ø)	⬇️
apps/dav/lib/Connector/Sabre/FilesPlugin.php	79.88% <100%> (-1.65%)	48 <0> (-3)
apps/dav/lib/Server.php	44.66% <100%> (+0.37%)	17 <0> (ø)	⬇️
apps/dav/lib/Connector/Sabre/Node.php	72.17% <83.33%> (+0.61%)	47 <4> (+4)	⬆️
apps/dav/lib/Upload/ChunkingPlugin.php	96.29% <96.29%> (ø)	8 <8> (?)
apps/files_trashbin/lib/Expiration.php	90.32% <0%> (-1.62%)	29% <0%> (ø)

[rullzer]

Lets do this!

[MorrisJobke]

For me the chunkingPlugin beforeMove is never called by uploading from the web UI. Also changing the size does not change anything. :/

[danxuliu]

@MorrisJobke Strange... Was the file larger than 10MiB (otherwise the chunking is not used)?

[MorrisJobke]

@MorrisJobke Strange... Was the file larger than 10MiB (otherwise the chunking is not used)?

Yes - but I will have another try, could be 10,5 MB and and 10,5 MiB.

[MorrisJobke]

Tested and works 👍