Cache final result of update check #7562
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the parsed data is not a valid response we should not cache it and only cache the preprocessed result set.
Fixes #7442
This method is called in
server/apps/updatenotification/lib/UpdateChecker.php
Line 44 in 0eebff1
If the
$data
instead of$tmp
is cached, then the returned value in the first call and the second call could be different, because a different object is cached causing the array access error in #7442.I also added a unit test to verify that a missing attribute still results in a proper result with all keys.