-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix box shadow of header elements #7572
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7572 +/- ##
============================================
+ Coverage 51.16% 51.16% +<.01%
Complexity 24883 24883
============================================
Files 1602 1602
Lines 94730 94730
Branches 1368 1368
============================================
+ Hits 48470 48471 +1
+ Misses 46260 46259 -1
|
Good stuff, but why reduce it from 10px which we used basically everywhere to 3px? It looks a bit strange and more like a thick border than a slight shadow. |
Because we use that in our newer filters ;) See the line I just changed, I thought that we move to that. Otherwise we need to touch a lot more occurrences. |
I disagree! The filter: drop-shadow is far better than the box-shadow as the arrow isn't included in the shadow generation. I'm against the removal of this. What's up with safari anyway? it should supports filter? https://caniuse.com/#feat=css-filters 😕 |
Usually it does this, but somehow not for the notifications drop down. I will check tomorrow and adapt this pr then |
ed4ada2
to
818fed6
Compare
Okay - I moved to the 10px and to the |
* unify shadow blur from 3px to 10px * remove opacity of background of app labels * for IE: use box-shadow as fallback (because the filter: drop-shadow is not supported) Signed-off-by: Morris Jobke <hey@morrisjobke.de>
818fed6
to
f854831
Compare
Found while reviewing nextcloud/notifications#89
cc @nextcloud/designers
Before (opacity,
bigger blur, no shadow on notifications in Safari):After: