Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable12] check userExists later, saves lookups for appData_INSTANCEID userids #7577

Merged
merged 1 commit into from
Dec 19, 2017
Merged

[stable12] check userExists later, saves lookups for appData_INSTANCEID userids #7577

merged 1 commit into from
Dec 19, 2017

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Dec 19, 2017

Backport of #7361

@blizzz @rullzer
check userExists later, saves lookups for appData_INSTANCEID userids
e788ae0 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@rullzer rullzer added the 3. to review Waiting for reviews label Dec 19, 2017
@rullzer rullzer added this to the Nextcloud 12.0.5 milestone Dec 19, 2017
@codecov
Copy link

codecov bot commented Dec 19, 2017 •
edited
Loading

Codecov Report

Merging #7577 into stable12 will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #7577      +/-   ##
==============================================
- Coverage       53.93%   53.93%   -0.01%     
  Complexity      22708    22708              
==============================================
  Files            1385     1385              
  Lines           86987    86987              
  Branches         1330     1330              
==============================================
- Hits            46918    46917       -1     
- Misses          40069    40070       +1
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Storage.php 77.55% <100%> (ø) 32 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)

@rullzer
Copy link
Member Author

rullzer commented Dec 19, 2017

Also 👍 from me so lets get this in

@rullzer rullzer merged commit 4ed99dd into stable12 Dec 19, 2017
@rullzer rullzer deleted the 7361_12 branch December 19, 2017 14:51
@MorrisJobke MorrisJobke mentioned this pull request Jan 8, 2018
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@schiessle schiessle Awaiting requested review from schiessle

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 12.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @MorrisJobke @blizzz