Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct SVG icon on share view #7580

Closed
wants to merge 1 commit into from
Closed

Conversation

pixelipo
Copy link
Contributor

Discovered while testing #7575 - it seems that $image-logo SCSS variable was pointing to a deprecated SVG image.
Before:
image
image

After:
image
image

Signed-off-by: Marin Treselj <marin@pixelipo.com>
@pixelipo pixelipo added 3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. regression labels Dec 19, 2017
@pixelipo pixelipo added this to the Nextcloud 13 milestone Dec 19, 2017
@pixelipo pixelipo self-assigned this Dec 19, 2017
@MorrisJobke
Copy link
Member

Acceptance tests fail:


  Scenario: open the menu in a public shared link                   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:26
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppContext::iShareTheLinkFor()
    And I write down the shared link                                # FilesAppContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # FilesSharingAppContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # FilesSharingAppContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -''
      +'about:blank'
    And I open the Share menu                                       # FilesSharingAppContext::iOpenTheShareMenu()
    Then I see that the Share menu is shown                         # FilesSharingAppContext::iSeeThatTheShareMenuIsShown()

@pixelipo
Copy link
Contributor Author

That's baffling. This PR could not possibly cause that failure. Any ideas?

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo should not be stretched to the whole container when we use the default Nextcloud logo. Similar to #4910

@MorrisJobke MorrisJobke mentioned this pull request Jan 2, 2018
30 tasks
@rullzer
Copy link
Member

rullzer commented Jan 2, 2018

@pixelipo any chance you can take a look at the comment from @juliushaertl ?

@MorrisJobke MorrisJobke closed this Jan 3, 2018
@MorrisJobke MorrisJobke deleted the show-default-logo branch January 3, 2018 10:17
@MorrisJobke
Copy link
Member

Merged as #7670 🤣

@juliusknorr
Copy link
Member

Addressed the logo sizing in #7678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants