Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide stay logged in checkbox when flow authentication is used #7590

Merged
merged 1 commit into from
Jan 2, 2018

Conversation

juliusknorr
Copy link
Member

Fix for #7234

@juliusknorr juliusknorr added 3. to review Waiting for reviews enhancement papercut Annoying recurring issue with possibly simple fix. labels Dec 20, 2017
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer rullzer force-pushed the flow-hide-stay-logged-in branch from 5ef5743 to f5f6ed6 Compare December 28, 2017 10:15
@codecov
Copy link

codecov bot commented Dec 28, 2017

Codecov Report

Merging #7590 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #7590      +/-   ##
============================================
- Coverage     51.17%   51.16%   -0.01%     
- Complexity    24886    24887       +1     
============================================
  Files          1602     1602              
  Lines         94752    94753       +1     
  Branches       1368     1368              
============================================
- Hits          48485    48482       -3     
- Misses        46267    46271       +4
Impacted Files Coverage Δ Complexity Δ
core/templates/login.php 0% <ø> (ø) 0 <0> (ø) ⬇️
core/Controller/LoginController.php 78.72% <100%> (+0.86%) 39 <0> (+1) ⬆️
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
core/js/js.js 62.98% <0%> (-0.57%) 0% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Server.php 81.55% <0%> (+0.11%) 134% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Jan 2, 2018
@MorrisJobke MorrisJobke merged commit 37ed5b5 into master Jan 2, 2018
@MorrisJobke MorrisJobke deleted the flow-hide-stay-logged-in branch January 2, 2018 10:27
This was referenced Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants