Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed top position of multiselected files table #7626

Merged
merged 1 commit into from
Dec 28, 2017
Merged

Fixed top position of multiselected files table #7626

merged 1 commit into from
Dec 28, 2017

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 26, 2017 •
edited
Loading

Fix #7625 @nextcloud/designers

@skjnldsv
Fixed top position of multiselected files table
84c9619 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. high regression labels Dec 26, 2017
@skjnldsv skjnldsv added this to the Nextcloud 13 milestone Dec 26, 2017
@skjnldsv skjnldsv self-assigned this Dec 26, 2017
@codecov
Copy link

codecov bot commented Dec 26, 2017 •
edited
Loading

Codecov Report

Merging #7626 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7626      +/-   ##
============================================
+ Coverage     51.17%   51.17%   +<.01%     
  Complexity    24886    24886              
============================================
  Files          1602     1602              
  Lines         94750    94750              
  Branches       1368     1368              
============================================
+ Hits          48485    48486       +1     
+ Misses        46265    46264       -1
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️

danxuliu
danxuliu approved these changes Dec 26, 2017
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@rullzer rullzer merged commit ea858fc into master Dec 28, 2017
@rullzer rullzer deleted the fixed-files-multiselect-top-margin branch December 28, 2017 10:22
@MorrisJobke MorrisJobke mentioned this pull request Jan 2, 2018
Merged
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@pixelipo pixelipo Awaiting requested review from pixelipo

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. high regression
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @rullzer @danxuliu