Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get correct translations for SecurityProvider #7659

Merged
merged 1 commit into from
Jan 2, 2018
Merged

Get correct translations for SecurityProvider #7659

merged 1 commit into from
Jan 2, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jan 2, 2018

Fixes #7657

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added the 3. to review Waiting for reviews label Jan 2, 2018
@rullzer rullzer added this to the Nextcloud 13 milestone Jan 2, 2018
Fixes #7657

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov
Copy link

codecov bot commented Jan 2, 2018

Codecov Report

Merging #7659 into master will increase coverage by 4.65%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #7659      +/-   ##
============================================
+ Coverage     29.15%   33.81%   +4.65%     
+ Complexity    23574    23573       -1     
============================================
  Files          1445     1445              
  Lines         78871    79253     +382     
============================================
+ Hits          22996    26798    +3802     
+ Misses        55875    52455    -3420
Impacted Files Coverage Δ Complexity Δ
settings/Activity/SecurityProvider.php 0% <0%> (-92.6%) 7 <0> (ø)
lib/private/Remote/Credentials.php 0% <0%> (-100%) 3% <0%> (ø)
.../private/App/CodeChecker/StrongComparisonCheck.php 0% <0%> (-100%) 7% <0%> (ø)
core/Command/Background/Base.php 0% <0%> (-100%) 3% <0%> (ø)
apps/dav/lib/CalDAV/PublicCalendarObject.php 0% <0%> (-100%) 1% <0%> (ø)
core/Command/Maintenance/Mimetype/UpdateDB.php 0% <0%> (-100%) 9% <0%> (ø)
apps/sharebymail/tests/SettingsTest.php 0% <0%> (-100%) 3% <0%> (ø)
core/Controller/UserController.php 0% <0%> (-100%) 4% <0%> (ø)
...s/encryption/lib/Controller/SettingsController.php 0% <0%> (-100%) 8% <0%> (ø)
...b/public/AppFramework/Http/FileDisplayResponse.php 0% <0%> (-100%) 3% <0%> (ø)
... and 841 more

@rullzer rullzer merged commit 9e49b6e into master Jan 2, 2018
@rullzer rullzer deleted the fix_7657 branch January 2, 2018 10:14
@MorrisJobke MorrisJobke mentioned this pull request Jan 2, 2018
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants