Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable12] Fix inverted app icons on IE11 #7684

Merged
merged 4 commits into from
Jan 9, 2018
Merged

[stable12] Fix inverted app icons on IE11 #7684

merged 4 commits into from
Jan 9, 2018

Conversation

juliusknorr
Copy link
Member

backport of #7669

please review @nextcloud/designers

@juliusknorr
Invert app icons on IE11 as well
a3b6f05 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix icon rendering in apps management for IE11
630d5db 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Remove css invert since we are using svg filters for now
b96278f 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix height of table rows in apps management on IE11
1d47410 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added 3. to review Waiting for reviews bug design Design, UI, UX, etc. labels Jan 3, 2018
@juliusknorr juliusknorr added this to the Nextcloud 12.0.5 milestone Jan 3, 2018
@juliusknorr juliusknorr mentioned this pull request Jan 3, 2018
Merged
@MorrisJobke MorrisJobke mentioned this pull request Jan 8, 2018
Merged
13 tasks
MorrisJobke
MorrisJobke approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 25ba9cb into stable12 Jan 9, 2018
@MorrisJobke MorrisJobke deleted the backport-ie-fix-invert branch January 9, 2018 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@pixelipo pixelipo Awaiting requested review from pixelipo

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 12.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @MorrisJobke @jancborchardt