Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LDAP Background Sync does not reset offset #7713

Merged
merged 7 commits into from
Jan 9, 2018
Merged

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 5, 2018

As observed on our instance… issue was that it was reported that more results are expected, while the count was already below the requested limit.

blizzz added 2 commits January 5, 2018 14:27
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 13 milestone Jan 5, 2018
@blizzz blizzz requested review from rullzer and MorrisJobke January 5, 2018 13:31
@codecov
Copy link

codecov bot commented Jan 5, 2018

Codecov Report

Merging #7713 into master will increase coverage by 0.05%.
The diff coverage is 24.39%.

@@             Coverage Diff              @@
##             master    #7713      +/-   ##
============================================
+ Coverage     51.18%   51.23%   +0.05%     
- Complexity    24948    24954       +6     
============================================
  Files          1605     1607       +2     
  Lines         94923    94957      +34     
  Branches       1376     1376              
============================================
+ Hits          48583    48652      +69     
+ Misses        46340    46305      -35
Impacted Files Coverage Δ Complexity Δ
...ps/user_ldap/composer/composer/autoload_static.php 0% <ø> (ø) 1 <0> (ø) ⬇️
apps/user_ldap/lib/ConnectionFactory.php 0% <0%> (ø) 2 <2> (?)
apps/user_ldap/lib/AccessFactory.php 0% <0%> (ø) 2 <2> (?)
.../user_ldap/composer/composer/autoload_classmap.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/user_ldap/lib/Jobs/Sync.php 64% <52.63%> (+37.61%) 46 <9> (+2) ⬆️

blizzz added 5 commits January 8, 2018 12:57
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Copy link
Member Author

blizzz commented Jan 8, 2018

I added several more tests, and fixed one issue with that.

On our instance I see that the offset is not being reset, this should have been fixed though, but isn't. New addition is about rotating the prefix which does not apply to us.

@MorrisJobke MorrisJobke merged commit 167f462 into master Jan 9, 2018
@MorrisJobke MorrisJobke deleted the fix-sync-offset branch January 9, 2018 17:39
@MorrisJobke MorrisJobke mentioned this pull request Jan 9, 2018
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants