Hide favourite icon in details view if favourite action is not available #7716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the favourite icon in the details view is clicked the "Favorite" action is triggered. However, if the action name given to "triggerAction" is not found then the "Download" action is triggered instead. As the "Favorite" action is not available in some file lists (like "Recents") the "Download" action was executed instead in those cases, which was a strange behaviour. Now the favourite icon is hidden if its action is not available. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
Codecov Report
@@ Coverage Diff @@
## master #7716 +/- ##
============================================
+ Coverage 51.18% 51.18% +<.01%
Complexity 24948 24948
============================================
Files 1605 1605
Lines 94923 94923
Branches 1376 1376
============================================
+ Hits 48583 48584 +1
+ Misses 46340 46339 -1
|
MorrisJobke
deleted the
hide-favourite-icon-in-details-view-if-favourite-action-is-not-available
branch
|
#962074 |
|
@danxuliu Could you open a backport against stable12? |
|
@MorrisJobke Here you have: #7742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (in master) #4568
The problem was that the Favorite file action is added only to some of the file lists, but the icon in the details view was shown unconditionally for every file list, so when it was clicked and the Favorite action was tried to be triggered it was not found and the Download action was executed instead.
Now the favourite icon is hidden if its action is not available.