Touch to zoom img preview #7734
Conversation
rullzer
commented
Jan 8, 2018
rullzer
commented
- Request a preview that covers the area and not fills it (better to have a few more pixels)
- Remove link of the preview so that tapping it works once again
Ask for a preview to cover the area. This makes sure we get a preview of at least the requested size. But it is better to have the browser scale down than up. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This should enable tap to zoom once again Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added
3. to review
rullzer
requested review from
jancborchardt,
danxuliu,
nickvergessen,
MorrisJobke,
ChristophWurst and
blizzz
Codecov Report
@@ Coverage Diff @@
## master #7734 +/- ##
============================================
+ Coverage 51.12% 51.18% +0.05%
Complexity 24948 24948
============================================
Files 1605 1605
Lines 94923 94922 -1
Branches 1376 1376
============================================
+ Hits 48528 48583 +55
+ Misses 46395 46339 -56
|
|
Hm, clicking an image doesn’t really seem to do anything? (Previously it opened the /preview URL) How to test this? :) |
|
@jancborchardt well now I'm confused... #7614 (comment) if you want to keep opening the /preview then we can just close this PR... However, we can't make it open the full original image as I mentioned. So your call. |
|
Mmmm ok so after thinking I think the opening of the preview just makes more sense. And now that we have higher default sizes (only for newly uploaded pictures). Opening /preview should be enough for now. Lets close this and if we want to have it do more/different think about this for 14. |
|
Ok, cool. I guess we were both confused there. :) And yeah, your other fix already does a lot of good towards not always needing to get a larger image. |
