-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opens comments links in _blank 🙊 #7739
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@
## master #7739 +/- ##
============================================
- Coverage 51.18% 51.18% -0.01%
Complexity 24948 24948
============================================
Files 1605 1605
Lines 94922 94922
Branches 1376 1376
============================================
- Hits 48584 48583 -1
- Misses 46338 46339 +1
|
Thanks a lot for fixing this @blizzz! :) 🎉 |
DefaultLinkOpen will enter appstore when the rc is available. |
@blizzz as soon as you or someone you have a call with accidentally drops from it as a result of clicking a link, I suggest you take it out of the store. ;) |
🙊 |
Btw, see this article: When to use target=”_blank”
@blizzz ;D |
@jancborchardt might very well be. My personal reality is different. My personal XP is that I am frustrated when new tabs open, when I want them to open where I am. This happens just too often, and there are already too many things going on in this world that are frustrating or worse. Please respect my attitude towards _blank. Please accept that it is as it is independent of how many honestly good reasons you find. I am able to open a link in a new tab when I intend to do so. This is deeply rooted in my muscle-or-whatever memory. |
cf. #7680 (comment) ff
I'll go and do an app that fixes this bug (imo) then later.
@jancborchardt