Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not instantiate node when not needed #7763

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Do not instantiate node when not needed #7763

merged 1 commit into from
Jan 10, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jan 9, 2018

Use the lazy functions is possible. This avoids getting the node if not
required.

Possible fix for #7751

@vasyugan could you test this patch?

Use the lazy functions is possible. This avoids getting the node if not
required.

Possible fix for #7751

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added 3. to review Waiting for reviews feature: sharing labels Jan 9, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Jan 10, 2018
@MorrisJobke MorrisJobke merged commit 4823ac9 into master Jan 10, 2018
@MorrisJobke MorrisJobke deleted the pos_fix_7751 branch January 10, 2018 14:44
@vasyugan
Copy link

sorry, saw this only now. Meanwhile I have manually removed the ghost entries from the database (some shares which pointed to nowhere) so I cannot test the patch anymore, unfortunately.

@ghost
Copy link

ghost commented Nov 21, 2019

sorry, saw this only now. Meanwhile I have manually removed the ghost entries from the database (some shares which pointed to nowhere) so I cannot test the patch anymore, unfortunately.

How did you delete the ghost entries?

I have the patch installed, but im getting the same error like in #7751

@vasyugan
Copy link

vasyugan commented Jan 23, 2020

sorry, saw this only now. Meanwhile I have manually removed the ghost entries from the database (some shares which pointed to nowhere) so I cannot test the patch anymore, unfortunately.

How did you delete the ghost entries?

I have the patch installed, but im getting the same error like in #7751

In the table oc_share, I searched for shares shared with the user for whom synchronisation fails and manually deleted the according table rows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants