Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds rel="noopener noreferrer" to _blank links inside comments #7787

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

tcitworld
Copy link
Member

For more details, check out https://mathiasbynens.github.io/rel-noopener/ for instance

Suggestion from #7680

For more details, check out https://mathiasbynens.github.io/rel-noopener/ for instance

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@rullzer rullzer added this to the Nextcloud 13 milestone Jan 11, 2018
@MorrisJobke MorrisJobke mentioned this pull request Jan 11, 2018
18 tasks
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 11, 2018
@codecov
Copy link

codecov bot commented Jan 11, 2018

Codecov Report

Merging #7787 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #7787   +/-   ##
=========================================
  Coverage     51.22%   51.22%           
  Complexity    24967    24967           
=========================================
  Files          1607     1607           
  Lines         95002    95002           
  Branches       1376     1376           
=========================================
  Hits          48668    48668           
  Misses        46334    46334
Impacted Files Coverage Δ Complexity Δ
core/js/public/comments.js 68.18% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
lib/private/Server.php 81.55% <0%> (+0.11%) 134% <0%> (ø) ⬇️

@rullzer rullzer merged commit 118ccca into master Jan 11, 2018
@rullzer rullzer deleted the add-noopener-to-_blank-links branch January 11, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: comments security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants