Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13] Use S3Client::upload instead of splitting single/multipart upload ourselves #8102

Merged
merged 1 commit into from
Feb 8, 2018
Merged

[13] Use S3Client::upload instead of splitting single/multipart upload ourselves #8102

merged 1 commit into from
Feb 8, 2018

Conversation

icewind1991
Copy link
Member

Backport of #8033

@icewind1991
Use S3Client::upload instead of splitting single/multipart upload our…
7ab3a7e 
…selves

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 29, 2018
@icewind1991 icewind1991 added this to the Nextcloud 13.0.1 milestone Jan 29, 2018
@codecov
Copy link

codecov bot commented Jan 29, 2018 •
edited
Loading

Codecov Report

Merging #8102 into stable13 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable13    #8102      +/-   ##
==============================================
+ Coverage       51.23%   51.23%   +<.01%     
+ Complexity      24981    24973       -8     
==============================================
  Files            1607     1607              
  Lines           95049    95020      -29     
  Branches         1376     1376              
==============================================
- Hits            48695    48684      -11     
+ Misses          46354    46336      -18
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/ObjectStore/S3ObjectTrait.php 75% <100%> (+17.1%) 5 <0> (-8) ⬇️
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
lib/private/Server.php 81.55% <0%> (+0.11%) 134% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

rullzer
rullzer approved these changes Jan 30, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit 197c97e into stable13 Feb 8, 2018
@MorrisJobke MorrisJobke deleted the s3-uploader-13 branch February 8, 2018 13:31
@MorrisJobke MorrisJobke mentioned this pull request Mar 9, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 13.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @rullzer @MorrisJobke