fix getting quota for public links with quota_include_external_storage #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @DeepDiver1975 and @blizzz to be potential reviewers |
|
sure - thank you. will test it and come back with my results. |
|
i do not have a file "lib/private/legacy/helper.php" |
|
older versions have the file at |
|
regarding to #848
The public upload still failed with a spinning wheel. |
|
@icewind1991 ready to review or still WIP? There is no status label |
|
review |
|
👍 |
|
LGTM |
|
Backport necessary @icewind1991 ? |
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
fix getting quota for public links with quota_include_external_storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With public links
\OCP\User::getUser()doesn't give us what we want.@riegercloud can you check if this fixes the problem for you