Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename dialog closed when not active #8485

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Rename dialog closed when not active #8485

merged 1 commit into from
Feb 26, 2018

Conversation

sagorika1996
Copy link
Member

Fixes #1433

@sagorika1996
rename dialog closed when not active
dca7544 
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
MorrisJobke
MorrisJobke approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

rullzer
rullzer approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @sagorika1996 thnx!

@rullzer rullzer merged commit 350b66b into nextcloud:master Feb 26, 2018
@rullzer
Copy link
Member

rullzer commented Feb 26, 2018

Thanks a lot for your fix @sagorika1996! Feel free to pick up more issues!

Also feel free to join the IRC channel #nextcloud-dev on FreeNode

@rullzer rullzer added this to the Nextcloud 14 milestone Feb 26, 2018
@sagorika1996 sagorika1996 deleted the rename branch March 1, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: files
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@sagorika1996 @rullzer @MorrisJobke