#8629 use a global unique identifier for each event sequence type #8640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rthday, anniversary, date of death) instead of one shared contact URI
|
Needs some re-work. UID "generation" needs to be done in caller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #8629.
Use a global unique identifier for each event sequence type (birthday, anniversary, date of death) instead of one shared contact URI.
Using the unique event ObjectUri/DateUri as event UID solved that issue for me.
Maybe someone could add some unit tests. (I could not find an existing unit test for that. So unit tests are not changed.)
Maybe someone could add a migration script to fix existing data in database.
Instructions to fix corrupt data:
Migration for existing corrupt VCALENDAR datasets can be healed with:
docker exec --user www-data nextcloudapp php occ dav:sync-birthday-calendar christian