Always remember me #9109
Merged
Always remember me #9109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8004 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added
3. to review
skjnldsv
approved these changes
Apr 6, 2018
MorrisJobke
reviewed
Apr 6, 2018
| @@ -240,7 +238,7 @@ private function generateRedirect($redirectUrl) { | |||
| * @param string $timezone_offset | |||
| * @return RedirectResponse | |||
| */ | |||
| public function tryLogin($user, $password, $redirect_url, $remember_login = false, $timezone = '', $timezone_offset = '') { | |||
| public function tryLogin($user, $password, $redirect_url, $remember_login = true, $timezone = '', $timezone_offset = '') { | |||
There was a problem hiding this comment.
Is the parameter still needed?
There was a problem hiding this comment.
It is used in a few places. We could get rid of it. But I want to do baby steps
jancborchardt
approved these changes
Apr 6, 2018
Codecov Report
@@ Coverage Diff @@
## master #9109 +/- ##
============================================
- Coverage 51.88% 51.88% -0.01%
+ Complexity 25297 25295 -2
============================================
Files 1603 1603
Lines 95060 95054 -6
Branches 1388 1388
============================================
- Hits 49325 49318 -7
- Misses 45735 45736 +1
|
juliusknorr
requested changes
Apr 6, 2018
| @@ -184,8 +185,6 @@ public function showLoginForm($user, $redirect_url, $remember_login) { | |||
| } | |||
|
|
|||
| $parameters['alt_login'] = OC_App::getAlternativeLogIns(); | |||
| $parameters['rememberLoginState'] = !empty($remember_login) ? $remember_login : 0; | |||
There was a problem hiding this comment.
The $remember_login parameter of this controller method can be removed.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8004
Remove remember me from the login page and just always remember.