-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add directdownload endpoint #9178
Conversation
Can I haz hooks for activities 🤓 |
@nickvergessen o yes please that would be awesome! |
@nickvergessen when do you want the hooks? On creation or on access? (or both?) |
Codecov Report
@@ Coverage Diff @@
## master #9178 +/- ##
============================================
- Coverage 51.92% 51.91% -0.02%
- Complexity 25388 25429 +41
============================================
Files 1608 1618 +10
Lines 95429 95644 +215
Branches 1394 1394
============================================
+ Hits 49555 49656 +101
- Misses 45874 45988 +114
|
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Tests * No directdownload from storage yet (as it is not tested at all) * No direct links for folders Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
393422a
to
1c75dda
Compare
Ok let do this. I can add the activity hooks later. @tobiasKaminsky already played around with it on android and it seems to do the job ;) |
Yes, from my side it is working :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Fixes #9142
A basic endpoint to allow clients to have an easy streaming endpoint (for example opening a file in VLC).
<server>/ocs/v2.php/apps/dav/api/v1/direct
withfileId=<x>
We first ask the storage for a link (S3 for example could provide this directly). Otherwise we generate a 60 char token.
The link thus only gives read access for a limited time.
The link is read only (of course)
The link is more than unique enough (just check 62^60)
Todo: