-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift v3 requires setting a scope #9280
Conversation
Unscoped auth is not guaranteed to return a catalog. So require the scope to be set properly. See https://developer.openstack.org/api-ref/identity/v3/index.html#password-authentication-with-unscoped-authorization Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@
## master #9280 +/- ##
============================================
- Coverage 51.95% 51.94% -0.01%
- Complexity 25382 25383 +1
============================================
Files 1608 1608
Lines 95413 95423 +10
Branches 1394 1394
============================================
Hits 49571 49571
- Misses 45842 45852 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense 👍
This will also need to be added to the external storage configuration then |
@icewind1991 fine. But lets do that in a separate pr ;) |
As long as we actually remember to make that follow up and not have a broken swift external storage. |
#11264 🤔 |
@icewind1991 mind to look into this again? |
Add an example of Swift V3 with a configuration scope following this commit : nextcloud/server#9280
Add an example of Swift V3 with a configuration scope following this commit : nextcloud/server#9280
Add an example of Swift V3 with a configuration scope following this commit : nextcloud/server#9280
Add an example of Swift V3 with a configuration scope following this commit : nextcloud/server#9280
Unscoped auth is not guaranteed to return a catalog. So require the
scope to be set properly.
See https://developer.openstack.org/api-ref/identity/v3/index.html#password-authentication-with-unscoped-authorization
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl