Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift v3 requires setting a scope #9280

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Apr 23, 2018

Unscoped auth is not guaranteed to return a catalog. So require the
scope to be set properly.

See https://developer.openstack.org/api-ref/identity/v3/index.html#password-authentication-with-unscoped-authorization

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Unscoped auth is not guaranteed to return a catalog. So require the
scope to be set properly.

See https://developer.openstack.org/api-ref/identity/v3/index.html#password-authentication-with-unscoped-authorization

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added bug 3. to review Waiting for reviews labels Apr 23, 2018
@rullzer rullzer added this to the Nextcloud 14 milestone Apr 23, 2018
@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

Merging #9280 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #9280      +/-   ##
============================================
- Coverage     51.95%   51.94%   -0.01%     
- Complexity    25382    25383       +1     
============================================
  Files          1608     1608              
  Lines         95413    95423      +10     
  Branches       1394     1394              
============================================
  Hits          49571    49571              
- Misses        45842    45852      +10
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/ObjectStore/SwiftFactory.php 0% <0%> (ø) 38 <0> (+1) ⬆️
config/config.sample.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@icewind1991
Copy link
Member

This will also need to be added to the external storage configuration then

@rullzer
Copy link
Member Author

rullzer commented Apr 24, 2018

@icewind1991 fine. But lets do that in a separate pr ;)

@icewind1991
Copy link
Member

As long as we actually remember to make that follow up and not have a broken swift external storage.

@kesselb
Copy link
Contributor

kesselb commented Jan 24, 2019

As long as we actually remember to make that follow up and not have a broken swift external storage.

#11264 🤔

@kesselb
Copy link
Contributor

kesselb commented May 10, 2019

@MorrisJobke 🏓

@MorrisJobke
Copy link
Member

@icewind1991 mind to look into this again?

alviss7 pushed a commit to alviss7/documentation that referenced this pull request Feb 27, 2020
Add an example of Swift V3 with a configuration scope following this commit :
nextcloud/server#9280
backportbot-nextcloud bot pushed a commit to nextcloud/documentation that referenced this pull request Apr 21, 2020
Add an example of Swift V3 with a configuration scope following this commit :
nextcloud/server#9280
MorrisJobke pushed a commit to nextcloud/documentation that referenced this pull request Apr 21, 2020
Add an example of Swift V3 with a configuration scope following this commit :
nextcloud/server#9280
backportbot-nextcloud bot pushed a commit to nextcloud/documentation that referenced this pull request Apr 21, 2020
Add an example of Swift V3 with a configuration scope following this commit :
nextcloud/server#9280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants